brooktrails/pr-reviewer
2
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

fix: derive VERSION from APP_VERSION env var instead of hardcoding #6

Merged
rcsheets merged 1 commit from fix/version-from-env into main 2026-03-20 21:42:44 +00:00
Conversation 1 Commits 1 Files changed 2 +2 -1
rcsheets commented 2026-03-20 21:41:21 +00:00
Owner
Copy link

VERSION was hardcoded and kept getting stale across releases. Now reads
from APP_VERSION env var (set in k8s deployment to match the image tag),
falling back to "dev" for local development.

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

VERSION was hardcoded and kept getting stale across releases. Now reads from APP_VERSION env var (set in k8s deployment to match the image tag), falling back to "dev" for local development. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
VERSION was hardcoded and kept getting stale across releases. Now reads
from APP_VERSION env var (set in k8s deployment to match the image tag),
falling back to "dev" for local development.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pr-reviewer-bot commented 2026-03-20 21:41:29 +00:00
Collaborator
Copy link

Automated review by pr-reviewer v0.8.0 | Safety Check | anthropic | tracking id r-bdbf03-6ec2e5

Status: ✅ Completed

Looking at this pull request, I can see it's a straightforward change to make the VERSION dynamic instead of hardcoded.

The changes are:

  • Adding app_version: str = "dev" to the Settings class in config.py
  • Changing VERSION = "0.8.0" to VERSION = settings.app_version in main.py

This looks like a clean improvement to avoid stale version numbers. The fallback to "dev" for local development is reasonable, and the approach of reading from an environment variable that matches the k8s image tag makes sense operationally.

No security issues, no accidentally committed files, and no obvious bugs in the logic.

Verdict: LGTM

*Automated review by [pr-reviewer](https://git.brooktrails.org/brooktrails/pr-reviewer) v0.8.0 | Safety Check | anthropic | tracking id `r-bdbf03-6ec2e5`* **Status:** ✅ Completed --- Looking at this pull request, I can see it's a straightforward change to make the VERSION dynamic instead of hardcoded. The changes are: - Adding `app_version: str = "dev"` to the Settings class in config.py - Changing `VERSION = "0.8.0"` to `VERSION = settings.app_version` in main.py This looks like a clean improvement to avoid stale version numbers. The fallback to "dev" for local development is reasonable, and the approach of reading from an environment variable that matches the k8s image tag makes sense operationally. No security issues, no accidentally committed files, and no obvious bugs in the logic. **Verdict: LGTM**
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
brooktrails/pr-reviewer!6
No description provided.