fix: show login landing page instead of immediate redirect #14

Merged

rcsheets merged 1 commit from fix/login-landing-page into main

2026-03-21 20:44:09 +00:00

rcsheets commented

2026-03-21 20:42:50 +00:00

Owner

Unauthenticated visitors see the teaser and a Log In button instead
of being immediately redirected to Keycloak. Friendlier UX and avoids
confusing errors if the OIDC redirect has issues.

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

Unauthenticated visitors see the teaser and a Log In button instead of being immediately redirected to Keycloak. Friendlier UX and avoids confusing errors if the OIDC redirect has issues. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

rcsheets added 1 commit

2026-03-21 20:42:50 +00:00

fix: show login landing page instead of immediate redirect 8077dd68b6

Unauthenticated visitors see the teaser and a Log In button instead
of being immediately redirected to Keycloak. Friendlier UX and avoids
confusing errors if the OIDC redirect has issues.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

pr-reviewer-bot commented

2026-03-21 20:42:51 +00:00

Collaborator

Automated review by pr-reviewer v0.14.0 | Safety Check | anthropic | tracking id r-bf02cb-c45500
This is an AI-generated review and may contain mistakes.

Status: ✅ Completed

✅ Verdict: LGTM — The changes improve UX by showing a login landing page instead of immediate redirect, with no obvious security or logic issues.

This PR replaces an immediate redirect to Keycloak with a friendlier landing page that shows a teaser and login button. The changes are straightforward:

Moves teaser = await _get_teaser() outside the OIDC check so it's available for both paths
Replaces RedirectResponse("/auth/login") with _render_login() call
Adds a new _render_login() function that renders an HTML page with teaser text and a login button
Adds simple CSS styling for the login button

The logic flow remains correct and the /auth/login endpoint is still used (just via a button click instead of automatic redirect). No security concerns or breaking changes identified.

*Automated review by [pr-reviewer](https://git.brooktrails.org/brooktrails/pr-reviewer) v0.14.0 | Safety Check | anthropic | tracking id `r-bf02cb-c45500`* *This is an AI-generated review and may contain mistakes.* **Status:** ✅ Completed --- **✅ Verdict: LGTM** — The changes improve UX by showing a login landing page instead of immediate redirect, with no obvious security or logic issues. This PR replaces an immediate redirect to Keycloak with a friendlier landing page that shows a teaser and login button. The changes are straightforward: - Moves `teaser = await _get_teaser()` outside the OIDC check so it's available for both paths - Replaces `RedirectResponse("/auth/login")` with `_render_login()` call - Adds a new `_render_login()` function that renders an HTML page with teaser text and a login button - Adds simple CSS styling for the login button The logic flow remains correct and the `/auth/login` endpoint is still used (just via a button click instead of automatic redirect). No security concerns or breaking changes identified.