feat(cli): log the build version at startup #59

Merged
rcsheets merged 1 commit from feat/startup-version-log into main 2026-08-04 21:37:44 +00:00
Owner

The "gllm starting" line reported model, addr, and backend but not which
build was serving them. That is the one field you want when a box is
misbehaving and the question is whether it is even running what you
think it is — and it was the only place to get it without querying the
server, which is exactly what you cannot do when it is not answering.

BuildVersion() already exists and already backs the status handler and
the endpoint index, so this reuses it rather than introducing a second
notion of "the version": a log line and an API response can be compared
directly. It resolves to the injected release version for container
builds, the VCS revision for a plain go build, and "unknown" for
go run or -buildvcs=false.

Co-Authored-By: Claude Opus 5 noreply@anthropic.com

The "gllm starting" line reported model, addr, and backend but not which build was serving them. That is the one field you want when a box is misbehaving and the question is whether it is even running what you think it is — and it was the only place to get it without querying the server, which is exactly what you cannot do when it is not answering. BuildVersion() already exists and already backs the status handler and the endpoint index, so this reuses it rather than introducing a second notion of "the version": a log line and an API response can be compared directly. It resolves to the injected release version for container builds, the VCS revision for a plain `go build`, and "unknown" for `go run` or -buildvcs=false. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
feat(cli): log the build version at startup
All checks were successful
ci / test_and_build (pull_request) Successful in 25s
6b01d54403
The "gllm starting" line reported model, addr, and backend but not which
build was serving them. That is the one field you want when a box is
misbehaving and the question is whether it is even running what you
think it is — and it was the only place to get it without querying the
server, which is exactly what you cannot do when it is not answering.

BuildVersion() already exists and already backs the status handler and
the endpoint index, so this reuses it rather than introducing a second
notion of "the version": a log line and an API response can be compared
directly. It resolves to the injected release version for container
builds, the VCS revision for a plain `go build`, and "unknown" for
`go run` or -buildvcs=false.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Collaborator

Automated review by pr-reviewer v0.44.2 | Safety Check | Claude Sonnet 5 | tracking id r-725b96-28f9f9
This is an AI-generated review and may contain mistakes.

Status: Completed


⚠️ The primary review (Mistral Small) failed. The review below is from Claude Sonnet 5, which reviewed the same diff.

Verdict: LGTM — Trivial, low-risk logging addition reusing an existing function; nothing alarming.

This is a small, low-risk change: it adds a "version" field to an existing log line by calling an already-existing engine.BuildVersion() function. No logic changes elsewhere, no new dependencies, no secrets or breaking changes. The lack of tests is a non-issue for a one-line logging addition.

*Automated review by [pr-reviewer](https://git.brooktrails.org/brooktrails/pr-reviewer) v0.44.2 | Safety Check | Claude Sonnet 5 | tracking id `r-725b96-28f9f9`* *This is an AI-generated review and may contain mistakes.* **Status:** ✅ Completed --- > ⚠️ The primary review (**Mistral Small**) failed. The review below is from **Claude Sonnet 5**, which reviewed the same diff. **✅ Verdict: LGTM** — Trivial, low-risk logging addition reusing an existing function; nothing alarming. This is a small, low-risk change: it adds a "version" field to an existing log line by calling an already-existing `engine.BuildVersion()` function. No logic changes elsewhere, no new dependencies, no secrets or breaking changes. The lack of tests is a non-issue for a one-line logging addition.
rcsheets deleted branch feat/startup-version-log 2026-08-04 21:37:45 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
brooktrails/gllm!59
No description provided.