perf(ci): run the 13.4 canary and GA probe after the push #54

Merged

rcsheets merged 1 commit from perf/ci-canary-after-push into main

2026-07-23 08:53:29 +00:00

rcsheets commented

2026-07-23 08:50:30 +00:00

Owner

Follow-up to #53 (this commit was mistakenly pushed to that branch after it merged; re-homed here).

The allowed-to-fail CUDA 13.4 canary (a full prerelease toolkit install plus kernel compile) and its GA-probe companion sat between the release builds and the push, delaying every release by their runtime. Both now run at the end of the job, after the image push and the git tag, where failing or dawdling can no longer hold anything up.

Both 13.4 steps move (not just the canary): they are documented as companions, and the GA probe turns into a full multi-GB build the day NVIDIA publishes the 13.4 base images -- it would become the next release-delayer otherwise. Their early-warning signal is unchanged: they still run on every main push, just after the release artifacts are already out.

🤖 Generated with Claude Code

Follow-up to #53 (this commit was mistakenly pushed to that branch after it merged; re-homed here). The allowed-to-fail CUDA 13.4 canary (a full prerelease toolkit install plus kernel compile) and its GA-probe companion sat between the release builds and the push, delaying every release by their runtime. Both now run at the end of the job, after the image push and the git tag, where failing or dawdling can no longer hold anything up. Both 13.4 steps move (not just the canary): they are documented as companions, and the GA probe turns into a full multi-GB build the day NVIDIA publishes the 13.4 base images -- it would become the next release-delayer otherwise. Their early-warning signal is unchanged: they still run on every main push, just after the release artifacts are already out. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

rcsheets added 1 commit

2026-07-23 08:50:30 +00:00

perf(ci): run the 13.4 canary and GA probe after the push

ci / test_and_build (pull_request) Successful in 22s

Details

a9cc7b0b8e

The allowed-to-fail CUDA 13.4 canary (a full prerelease toolkit install
plus kernel compile) and its GA-probe companion (a full build too, the
day NVIDIA publishes the base images) sat between the release builds
and the push, delaying every release by their runtime. Move both to the
end of the job, after the image push and the git tag, where failing or
dawdling can no longer hold anything up.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

pr-reviewer-bot commented

2026-07-23 08:50:31 +00:00

Collaborator

Automated review by pr-reviewer v0.37.0 | Safety Check | Claude Sonnet 5 | tracking id r-61d5d7-1795c3
This is an AI-generated review and may contain mistakes.

Status: ✅ Completed

⚠️ The primary review (Mistral Small) failed. The review below is from Claude Sonnet 5, which reviewed the same diff.

✅ Verdict: LGTM — Simple reordering of two non-blocking CI steps with no logic changes; nothing alarming.

This is a straightforward reordering of two CI steps (CUDA 13.4 canary build and GA probe) from before the push/tag steps to after them. Both steps are unchanged in content — same continue-on-error: true, same build commands, same comments (with a minor addition explaining the reordering rationale). No logic changes, no new secrets, no credentials, and the steps remain build-only (never pushed/tagged to registry). This matches the PR description exactly: purely a move to avoid delaying releases, with no behavior change to the steps themselves.

*Automated review by [pr-reviewer](https://git.brooktrails.org/brooktrails/pr-reviewer) v0.37.0 | Safety Check | Claude Sonnet 5 | tracking id `r-61d5d7-1795c3`* *This is an AI-generated review and may contain mistakes.* **Status:** ✅ Completed --- > ⚠️ The primary review (**Mistral Small**) failed. The review below is from **Claude Sonnet 5**, which reviewed the same diff. **✅ Verdict: LGTM** — Simple reordering of two non-blocking CI steps with no logic changes; nothing alarming. This is a straightforward reordering of two CI steps (CUDA 13.4 canary build and GA probe) from before the push/tag steps to after them. Both steps are unchanged in content — same `continue-on-error: true`, same build commands, same comments (with a minor addition explaining the reordering rationale). No logic changes, no new secrets, no credentials, and the steps remain build-only (never pushed/tagged to registry). This matches the PR description exactly: purely a move to avoid delaying releases, with no behavior change to the steps themselves.

rcsheets force-pushed perf/ci-canary-after-push from a9cc7b0b8e

ci / test_and_build (pull_request) Successful in 22s

Details

to f82dcc1783

ci / test_and_build (pull_request) Successful in 23s

Details

2026-07-23 08:51:41 +00:00

Compare

pr-reviewer-bot commented

2026-07-23 08:51:42 +00:00

Collaborator

Automated review by pr-reviewer v0.37.0 | Safety Check | Claude Sonnet 5 | tracking id r-61d61e-07f13e
This is an AI-generated review and may contain mistakes.

Status: ✅ Completed

⚠️ The primary review (Mistral Small) failed. The review below is from Claude Sonnet 5, which reviewed the same diff.

✅ Verdict: LGTM — Straightforward reordering of two allowed-to-fail CI steps to run after the push/tag steps, matching the stated intent with no logic or risk changes.

The diff simply relocates two continue-on-error: true steps (CUDA 13.4 canary build and GA probe) from before the image push/tag steps to after them, with no logic changes to the steps themselves. Both steps retain their continue-on-error: true flag, so this reordering doesn't risk blocking the pipeline, and it matches the stated intent (avoid delaying releases with allowed-to-fail, long-running steps). No secrets, credentials, or unrelated files are touched; change is isolated to the workflow YAML. This is a low-risk CI reordering change.

*Automated review by [pr-reviewer](https://git.brooktrails.org/brooktrails/pr-reviewer) v0.37.0 | Safety Check | Claude Sonnet 5 | tracking id `r-61d61e-07f13e`* *This is an AI-generated review and may contain mistakes.* **Status:** ✅ Completed --- > ⚠️ The primary review (**Mistral Small**) failed. The review below is from **Claude Sonnet 5**, which reviewed the same diff. **✅ Verdict: LGTM** — Straightforward reordering of two allowed-to-fail CI steps to run after the push/tag steps, matching the stated intent with no logic or risk changes. The diff simply relocates two `continue-on-error: true` steps (CUDA 13.4 canary build and GA probe) from before the image push/tag steps to after them, with no logic changes to the steps themselves. Both steps retain their `continue-on-error: true` flag, so this reordering doesn't risk blocking the pipeline, and it matches the stated intent (avoid delaying releases with allowed-to-fail, long-running steps). No secrets, credentials, or unrelated files are touched; change is isolated to the workflow YAML. This is a low-risk CI reordering change.

rcsheets merged commit 1454de1e1e into main

2026-07-23 08:53:29 +00:00

rcsheets deleted branch perf/ci-canary-after-push

2026-07-23 08:53:29 +00:00

rcsheets referenced this pull request from a commit

2026-07-23 08:53:30 +00:00

Merge pull request 'perf(ci): run the 13.4 canary and GA probe after the push' (#54) from perf/ci-canary-after-push into main