refactor: rename identifiers that differed from a neighbour only by case #103
Loading…
Reference in a new issue
No description provided.
Delete branch "style/case-only-names"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
Two places use a pair of names in one scope that differ only in capitalisation, so they read as one name:
kvcache.Manager.matchBlocksholds the block size inBnext to a block pointerb.rowsfield ofgllm_nvfp4_groupbeside theROWStemplate parameter.Change
BbecomessizeinmatchBlocks.rowsfield ofgllm_nvfp4_groupbecomesnrows, ingllm_kernels.h,kernels.cuand the Go caller that fills the struct (grouped.go).Pairs left alone on purpose: a generic test helper's type parameter
Tbeside its*testing.Targumentt, and theGLLM_TARGET_SMSmacro beside thegllm_target_sms()function that returns it.Merge order
This branch is based on #102 (
perf/nvfp4-gemv-rows), which rewrites the kernel lines the field rename touches. Until #102 merges, this PR also shows its commit; merge #102 first.Verification
kernels.cuis identical before and after for sm_86 and sm_120, so the device code is unchanged.go test ./internal/kvcache/passes.go build ./..., thecuda-tagged build ofcmd/gllmand thecuda-tagged test binary forinternal/backend/cudaall compile.Not run: the CUDA tests on a GPU. The host-side launcher change is the field rename only.
🤖 Generated with Claude Code
Automated review by pr-reviewer v0.52.3 | Safety Check | Ministral 3 Instruct | tracking id
r-be1f8e-c768eaThis is an AI-generated review and may contain mistakes.
Status: ❌ Failed
This review couldn't be completed: that model isn't loaded on the inference service right now, and no alternate model was able to review it either. Consider splitting this PR into smaller changes. Tracking id
r-be1f8e-c768ea.Comment
@pr-reviewer-bot retryto try again.