feat(cli): log the build version at startup #59
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/startup-version-log"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The "gllm starting" line reported model, addr, and backend but not which
build was serving them. That is the one field you want when a box is
misbehaving and the question is whether it is even running what you
think it is — and it was the only place to get it without querying the
server, which is exactly what you cannot do when it is not answering.
BuildVersion() already exists and already backs the status handler and
the endpoint index, so this reuses it rather than introducing a second
notion of "the version": a log line and an API response can be compared
directly. It resolves to the injected release version for container
builds, the VCS revision for a plain
go build, and "unknown" forgo runor -buildvcs=false.Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Automated review by pr-reviewer v0.44.2 | Safety Check | Claude Sonnet 5 | tracking id
r-725b96-28f9f9This is an AI-generated review and may contain mistakes.
Status: ✅ Completed
✅ Verdict: LGTM — Trivial, low-risk logging addition reusing an existing function; nothing alarming.
This is a small, low-risk change: it adds a "version" field to an existing log line by calling an already-existing
engine.BuildVersion()function. No logic changes elsewhere, no new dependencies, no secrets or breaking changes. The lack of tests is a non-issue for a one-line logging addition.