brooktrails/forgejo-runner-operator
Watch
1
0
Fork
You've already forked forgejo-runner-operator
 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity Actions

refactor: drop the admin-registrar component #52

Merged
rcsheets merged 1 commit from refactor/drop-admin-registrar into main 2026-07-20 02:08:55 +00:00
Conversation 2 Commits 1 Files changed 17 +6 -2340
rcsheets commented 2026-07-20 01:55:52 +00:00
Owner
Copy link

The admin-registrar never worked out and is being removed. Deletes the
binary (cmd/admin-registrar), its package (internal/registrar), and its
image (Containerfile.admin-registrar), plus the build/publish wiring in
the Makefile and publish.yml and the doc mention in runner-images/README.

Also removes the now-dead code the registrar was the sole consumer of: the
admin user/collaborator methods in internal/forgejo (CreateUser, GetUser,
DeleteUser, AddCollaborator, CreateUserToken, GetRepoByID, ListRepos and
their RepoInfo/CreateUserOptions types, verified to have no other callers)
and the ActionAdmin* audit constants. The shared forgejo runner-management
methods and the audit package are otherwise untouched.

Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com

The admin-registrar never worked out and is being removed. Deletes the binary (cmd/admin-registrar), its package (internal/registrar), and its image (Containerfile.admin-registrar), plus the build/publish wiring in the Makefile and publish.yml and the doc mention in runner-images/README. Also removes the now-dead code the registrar was the sole consumer of: the admin user/collaborator methods in internal/forgejo (CreateUser, GetUser, DeleteUser, AddCollaborator, CreateUserToken, GetRepoByID, ListRepos and their RepoInfo/CreateUserOptions types, verified to have no other callers) and the ActionAdmin* audit constants. The shared forgejo runner-management methods and the audit package are otherwise untouched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
refactor: drop the admin-registrar component
Some checks failed
CI / ci (pull_request) Has been cancelled
Details
E2E smoke test / e2e (pull_request) Has been cancelled
Details
CI (next Go) / next-go (tip) (pull_request) Has been cancelled
Details
132a85074b 
The admin-registrar never worked out and is being removed. Deletes the
binary (cmd/admin-registrar), its package (internal/registrar), and its
image (Containerfile.admin-registrar), plus the build/publish wiring in
the Makefile and publish.yml and the doc mention in runner-images/README.

Also removes the now-dead code the registrar was the sole consumer of: the
admin user/collaborator methods in internal/forgejo (CreateUser, GetUser,
DeleteUser, AddCollaborator, CreateUserToken, GetRepoByID, ListRepos and
their RepoInfo/CreateUserOptions types, verified to have no other callers)
and the ActionAdmin* audit constants. The shared forgejo runner-management
methods and the audit package are otherwise untouched.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
pr-reviewer-bot commented 2026-07-20 01:55:53 +00:00
Collaborator
Copy link

Automated review by pr-reviewer v0.32.2 | Safety Check | Mistral Small | tracking id r-5d8029-975dbf
This is an AI-generated review and may contain mistakes.

Status: ⚠️ Unavailable

Review unavailable — the inference service isn't reachable right now. This isn't a problem with your PR. Tracking id r-5d8029-975dbf.

Comment @pr-reviewer-bot retry once it's back.

*Automated review by [pr-reviewer](https://git.brooktrails.org/brooktrails/pr-reviewer) v0.32.2 | Safety Check | Mistral Small | tracking id `r-5d8029-975dbf`* *This is an AI-generated review and may contain mistakes.* **Status:** ⚠️ Unavailable --- Review unavailable — the inference service isn't reachable right now. This isn't a problem with your PR. Tracking id `r-5d8029-975dbf`. Comment `@pr-reviewer-bot retry` once it's back.
rcsheets force-pushed refactor/drop-admin-registrar from 132a85074b
Some checks failed
CI / ci (pull_request) Has been cancelled
Details
E2E smoke test / e2e (pull_request) Has been cancelled
Details
CI (next Go) / next-go (tip) (pull_request) Has been cancelled
Details
to 77a43f0e74
All checks were successful
CI (next Go) / next-go (tip) (pull_request) Successful in 5m30s
Details
CI / ci (pull_request) Successful in 1m54s
Details
E2E smoke test / e2e (pull_request) Successful in 4m57s
Details
2026-07-20 01:55:57 +00:00 Compare
pr-reviewer-bot commented 2026-07-20 01:55:59 +00:00
Collaborator
Copy link

Automated review by pr-reviewer v0.32.2 | Safety Check | Mistral Small | tracking id r-5d802f-3a591c
This is an AI-generated review and may contain mistakes.

Status: ⚠️ Unavailable

Review unavailable — the inference service isn't reachable right now. This isn't a problem with your PR. Tracking id r-5d802f-3a591c.

Comment @pr-reviewer-bot retry once it's back.

*Automated review by [pr-reviewer](https://git.brooktrails.org/brooktrails/pr-reviewer) v0.32.2 | Safety Check | Mistral Small | tracking id `r-5d802f-3a591c`* *This is an AI-generated review and may contain mistakes.* **Status:** ⚠️ Unavailable --- Review unavailable — the inference service isn't reachable right now. This isn't a problem with your PR. Tracking id `r-5d802f-3a591c`. Comment `@pr-reviewer-bot retry` once it's back.
rcsheets deleted branch refactor/drop-admin-registrar 2026-07-20 02:08:56 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
brooktrails/forgejo-runner-operator!52
No description provided.