fix(kubernetes): don't make non-DinD runners ping a docker daemon #31
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/non-dind-runner-docker-host"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
A RunnerPool without privileged/dockerImage has no DinD sidecar, yet the
generated runner container still received DOCKER_HOST=tcp://localhost:2375
and the default config used docker_host: "" (auto-detect). On startup
forgejo-runner pinged a daemon that does not exist and crashlooped:
Error: cannot ping the docker daemon. is it running?
Cannot connect to the Docker daemon at tcp://localhost:2375.
Only set DOCKER_HOST on the runner container when a DinD sidecar is
present, and generate docker_host: "-" (disable the docker client, run
jobs on the host) for non-privileged pools instead of "".
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
This also wound up bringing in a huge number of CI fixes.
Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3ceb80-5b7ff8This is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3ceb80-5b7ff8— see logs for details.Comment
@pr-reviewer-bot retryto try again.The operator's own CI was stuck ("Waiting for a runner with the following label: ubuntu-latest") because no such runner exists. The dedicated pool for this repo (trusted-forgejo-runner-operator) registers the labels [trusted dind runner-operator], matching the convention used by the other repos' build/publish workflows. Point all four workflows at [dind, trusted] so the existing runner picks them up. All of them need Docker anyway (ci builds container images, e2e runs kind, publish does docker build/push). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3cedeb-da8cc5This is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3cedeb-da8cc5— see logs for details.Comment
@pr-reviewer-bot retryto try again.sudoinvocationAutomated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3cf647-5d6f6cThis is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3cf647-5d6f6c— see logs for details.Comment
@pr-reviewer-bot retryto try again.Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3cf708-a46ed7This is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3cf708-a46ed7— see logs for details.Comment
@pr-reviewer-bot retryto try again.Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3cf745-d4c81bThis is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3cf745-d4c81b— see logs for details.Comment
@pr-reviewer-bot retryto try again.Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3cf7b5-c5ee02This is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3cf7b5-c5ee02— see logs for details.Comment
@pr-reviewer-bot retryto try again.Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3cf80a-95cc89This is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3cf80a-95cc89— see logs for details.Comment
@pr-reviewer-bot retryto try again.Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3d1508-acba70This is an AI-generated reveiw and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3d1508-acba70— see logs for details.Comment
@pr-reviewer-bot retryto try again.Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3d15ae-4747adThis is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3d15ae-4747ad— see logs for details.Comment
@pr-reviewer-bot retryto try again.Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3d1678-53a99cThis is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3d1678-53a99c— see logs for details.Comment
@pr-reviewer-bot retryto try again.Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3d16df-385ac0This is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3d16df-385ac0— see logs for details.Comment
@pr-reviewer-bot retryto try again.Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3d181f-acdea5This is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3d181f-acdea5— see logs for details.Comment
@pr-reviewer-bot retryto try again.Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3d1989-9b29ddThis is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3d1989-9b29dd— see logs for details.Comment
@pr-reviewer-bot retryto try again.Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3d19e2-4894fcThis is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3d19e2-4894fc— see logs for details.Comment
@pr-reviewer-bot retryto try again.push was triggering on every branch ("**") while pull_request also fired for the open PR, so each commit on a PR branch ran CI twice. Restrict push to master (post-merge gate) and let pull_request cover branch validation, matching e2e.yml. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3d1c70-ecf310This is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3d1c70-ecf310— see logs for details.Comment
@pr-reviewer-bot retryto try again.Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3d1cc3-c407ceThis is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3d1cc3-c407ce— see logs for details.Comment
@pr-reviewer-bot retryto try again.Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3d1edc-edd35aThis is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3d1edc-edd35a— see logs for details.Comment
@pr-reviewer-bot retryto try again.Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3d1f1f-e471afThis is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3d1f1f-e471af— see logs for details.Comment
@pr-reviewer-bot retryto try again.Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3d21c5-a0559dThis is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3d21c5-a0559d— see logs for details.Comment
@pr-reviewer-bot retryto try again.Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3d237e-c695feThis is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3d237e-c695fe— see logs for details.Comment
@pr-reviewer-bot retryto try again.Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3d244f-6f7356This is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3d244f-6f7356— see logs for details.Comment
@pr-reviewer-bot retryto try again.Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3d27c3-6cac34This is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3d27c3-6cac34— see logs for details.Comment
@pr-reviewer-bot retryto try again.Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3d2ae4-b0f3f2This is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3d2ae4-b0f3f2— see logs for details.Comment
@pr-reviewer-bot retryto try again.Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3d3102-1c8c63This is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3d3102-1c8c63— see logs for details.Comment
@pr-reviewer-bot retryto try again.Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3d363b-5a558aThis is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3d363b-5a558a— see logs for details.Comment
@pr-reviewer-bot retryto try again.This runner doesn't interpolate ${{ matrix.go-version }} in step names, so the title showed the literal expression. Use a static name and echo the resolved version into the step log instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>Automated review by pr-reviewer v0.29.1 | Safety Check | Mistral Small | tracking id
r-3d36c3-656372This is an AI-generated review and may contain mistakes.
Status: ❌ Failed
Review failed. Tracking id
r-3d36c3-656372— see logs for details.Comment
@pr-reviewer-bot retryto try again.