feat: add a runner type without DinD for buildah-based build pipelines #29
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Now that
brooktrails/pr-reviewer'sbuild-push.yamlhas migrated fromdocker buildtobuildah bud(withpodmanfor the smoke test), it no longer needs a Docker-in-Docker sidecar. The currentruns-on: [dind, trusted]selector still routes the job to a runner pool that brings up DinD as an unused dependency — extra pod startup time, extra memory, an extra privileged container that isn't doing anything.Once a couple more workflows make the same migration (notably
brooktrails/brooktrails-web'sbuild-push.yaml), it would be worth defining a new lightweight runner type that:[trusted]already implies for elevated capabilities (cgroup access, etc.).buildahoroci-build) so workflows can opt in deliberately rather than landing on it implicitly.After that's available,
pr-reviewer'sruns-onbecomes[buildah, trusted](or whatever the chosen tag is) and the unused DinD sidecar drops away.Open questions:
dindrunner type entirely once nothing references it, or keep both around for now.[trusted]already grants? (We currently forcevfsstorage andchrootisolation specifically because the runner doesn't have privileges to use overlay or runc-with-namespaces. A more privileged runner could lift those.)