refactor(server): improve path handling and add tests #1

Merged

rcsheets merged 31 commits from feature/improve-path-handling into main

2025-03-16 07:07:37 +00:00

rcsheets commented

2025-03-11 06:21:28 +00:00

(Migrated from github.com)

Add ObjectStore interface for better testability
Create robust cleanRequestPath function
Add comprehensive test suite for path handling
Improve directory traversal prevention

- Add ObjectStore interface for better testability - Create robust cleanRequestPath function - Add comprehensive test suite for path handling - Improve directory traversal prevention

RadicalMagenta (Migrated from github.com) reviewed

2025-03-11 06:21:28 +00:00

github-advanced-security[bot] commented

2025-03-11 06:40:28 +00:00

(Migrated from github.com)

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on [this overview](/picotechllc/spray/security/code-scanning?query=pr%3A1+is%3Aopen). Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out [the documentation](https://docs.github.com/code-security/code-scanning/introduction-to-code-scanning/about-code-scanning).

grue commented

2025-03-15 20:46:20 +00:00

(Migrated from github.com)

Have you considered https://github.com/spf13/cobra for arg parsing, flags, env var, and config wrangling?

rcsheets commented

2025-03-16 01:19:16 +00:00

(Migrated from github.com)

Have you considered https://github.com/spf13/cobra for arg parsing, flags, env var, and config wrangling?

I have not. That could certainly go into a separate PR. This one is already bigger than I wanted.

> Have you considered https://github.com/spf13/cobra for arg parsing, flags, env var, and config wrangling? I have not. That could certainly go into a separate PR. This one is already bigger than I wanted.

grue (Migrated from github.com) approved these changes

2025-03-16 04:44:49 +00:00