fix: numeric input + non-negative for per-config pricing fields

rcsheets commented

2026-05-05 08:37:53 +00:00

Owner

Per-config input_per_mtok / output_per_mtok inputs were type=text
with placeholder examples, parsed via strconv.ParseFloat with the
error silently discarded. Locale-y input like "3,00" or a typo would
just blank the field with no feedback to the operator.

Switch the two pricing fields (in both the create and edit forms)
to type=number step=0.0001 min=0, which lets the browser reject
non-numeric input and negative values before submit. Server-side
ParseFloat failures still log a Warn line — same semantics as
before, just no longer mute, in case a non-browser client posts
malformed data.

Temperature stays type=text since it has its own existing range
copy and isn't part of the spend rollup; revisit separately if
desired.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

Per-config input_per_mtok / output_per_mtok inputs were type=text with placeholder examples, parsed via strconv.ParseFloat with the error silently discarded. Locale-y input like "3,00" or a typo would just blank the field with no feedback to the operator. Switch the two pricing fields (in both the create and edit forms) to type=number step=0.0001 min=0, which lets the browser reject non-numeric input and negative values before submit. Server-side ParseFloat failures still log a Warn line — same semantics as before, just no longer mute, in case a non-browser client posts malformed data. Temperature stays type=text since it has its own existing range copy and isn't part of the spend rollup; revisit separately if desired. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

rcsheets added 1 commit

2026-05-05 08:37:53 +00:00

fix: numeric input + non-negative for per-config pricing fields

ci / check (pull_request) Has been cancelled

Details

5055b01d1e

Per-config input_per_mtok / output_per_mtok inputs were type=text
with placeholder examples, parsed via strconv.ParseFloat with the
error silently discarded. Locale-y input like "3,00" or a typo would
just blank the field with no feedback to the operator.

Switch the two pricing fields (in both the create and edit forms)
to type=number step=0.0001 min=0, which lets the browser reject
non-numeric input and negative values before submit. Server-side
ParseFloat failures still log a Warn line — same semantics as
before, just no longer mute, in case a non-browser client posts
malformed data.

Temperature stays type=text since it has its own existing range
copy and isn't part of the spend rollup; revisit separately if
desired.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

pr-reviewer-bot commented

2026-05-05 08:37:54 +00:00

Collaborator

Automated review by pr-reviewer v0.28.0 | Safety Check | Claude Sonnet 4 | tracking id r-f9ac62-5fe0ee
This is an AI-genrated review and may contain mistakes.

Status: ⏳ Pending

Running a quick safety check on this PR using Claude Sonnet 4. This is just a sanity check — for a full review, assign me as a reviewer or comment @pr-reviewer-bot review.

*Automated review by [pr-reviewer](https://git.brooktrails.org/brooktrails/pr-reviewer) v0.28.0 | Safety Check | Claude Sonnet 4 | tracking id `r-f9ac62-5fe0ee`* *This is an AI-genrated review and may contain mistakes.* **Status:** ⏳ Pending --- Running a quick **safety check** on this PR using `Claude Sonnet 4`. This is just a sanity check — for a full review, assign me as a reviewer or comment `@pr-reviewer-bot review`.

rcsheets force-pushed fix/admin-form-numeric-pricing from 5055b01d1e

ci / check (pull_request) Has been cancelled

Details

to 33e6ce4aa4

ci / check (pull_request) Successful in 43s

Details

2026-05-05 08:38:23 +00:00

Compare

rcsheets merged commit fb8ae42732 into main

2026-05-05 08:42:17 +00:00

rcsheets referenced this pull request from a commit

2026-05-05 08:42:19 +00:00