brooktrails/forgejo-runner-operator
2
0
Fork 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity Actions

fix: create PVC during RunnerPool reconciliation #20

Merged
rcsheets merged 1 commit from fix/reconcile-pvc into master 2026-03-27 06:44:38 +00:00
Conversation 1 Commits 1 Files changed 1 +31 -1
rcsheets commented 2026-03-27 06:43:16 +00:00
Owner
Copy link

BuildPVC existed but was never called in reconcileKubernetes,
causing pods to fail with "persistentvolumeclaim not found" when
storage was configured on the RunnerPool spec.

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

BuildPVC existed but was never called in reconcileKubernetes, causing pods to fail with "persistentvolumeclaim not found" when storage was configured on the RunnerPool spec. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
fix: create PVC during RunnerPool reconciliation
Some checks failed
CI / ci (push) Has been cancelled
Details
CI / ci (pull_request) Has been cancelled
Details
E2E smoke test / e2e (pull_request) Has been cancelled
Details
c34b0dcc4e 
BuildPVC existed but was never called in reconcileKubernetes,
causing pods to fail with "persistentvolumeclaim not found" when
storage was configured on the RunnerPool spec.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pr-reviewer-bot commented 2026-03-27 06:43:18 +00:00
Collaborator
Copy link

Automated review by pr-reviewer v0.15.0 | Safety Check | anthropic | tracking id r-c62705-9eead0
This is an AI-generated review and may contain mistakes.

Status: ✅ Completed

✅ Verdict: LGTM — This is a straightforward bug fix that adds missing PVC reconciliation logic to prevent pod failures.
Complexity: moderate

Safety Check

This change adds PVC reconciliation logic that was missing from the controller. The implementation follows standard Kubernetes controller patterns:

  • Uses CreateOrUpdate with proper controller reference setting
  • Correctly handles PVC spec immutability (only sets spec on creation)
  • Includes appropriate error handling and logging
  • Follows the same pattern as other resource reconciliation in the function

The fix addresses a real bug where pods would fail due to missing PVCs when storage was configured. Nothing alarming detected.

*Automated review by [pr-reviewer](https://git.brooktrails.org/brooktrails/pr-reviewer) v0.15.0 | Safety Check | anthropic | tracking id `r-c62705-9eead0`* *This is an AI-generated review and may contain mistakes.* **Status:** ✅ Completed --- **✅ Verdict: LGTM** — This is a straightforward bug fix that adds missing PVC reconciliation logic to prevent pod failures. **Complexity:** moderate # Safety Check This change adds PVC reconciliation logic that was missing from the controller. The implementation follows standard Kubernetes controller patterns: - Uses `CreateOrUpdate` with proper controller reference setting - Correctly handles PVC spec immutability (only sets spec on creation) - Includes appropriate error handling and logging - Follows the same pattern as other resource reconciliation in the function The fix addresses a real bug where pods would fail due to missing PVCs when storage was configured. Nothing alarming detected.
rcsheets merged commit d72df3e122 into master 2026-03-27 06:44:38 +00:00
rcsheets deleted branch fix/reconcile-pvc 2026-03-27 06:44:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
brooktrails/forgejo-runner-operator!20
No description provided.