fix: use GET for registration token endpoints #19

Merged

rcsheets merged 1 commit from fix/registration-token-get into master 2026-03-27 06:30:18 +00:00

Conversation 2 Commits 1 Files changed 2 +6 -13

rcsheets commented 2026-03-27 06:29:30 +00:00

Owner

Copy link

Forgejo 14.x serves registration tokens via GET, not POST. All three
endpoints (admin, org, repo) were sending POST requests, which
returned 405 Method Not Allowed.

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

Forgejo 14.x serves registration tokens via GET, not POST. All three endpoints (admin, org, repo) were sending POST requests, which returned 405 Method Not Allowed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

rcsheets added 1 commit 2026-03-27 06:29:30 +00:00

fix: use GET for registration token endpoints ... 76fef160df

Forgejo 14.x serves registration tokens via GET, not POST. All three
endpoints (admin, org, repo) were sending POST requests, which
returned 405 Method Not Allowed.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

pr-reviewer-bot commented 2026-03-27 06:29:32 +00:00

Collaborator

Copy link

Automated review by pr-reviewer v0.15.0 | Safety Check | anthropic | tracking id r-c623cb-46fe0c
This is an AI-generated review and may contain -istakes.

Status: ✅ Completed

---

✅ Verdict: LGTM — The change correctly switches from POST to GET requests for registration token endpoints to match Forgejo 14.x API, with proper test updates.
Complexity: trivial

Safety Check Review

This PR fixes a compatibility issue with Forgejo 14.x by changing HTTP method from POST to GET for registration token endpoints. The changes are straightforward:

• Changes HTTP method from POST to GET for all three registration token endpoints
• Removes unnecessary JSON body and Content-Type header since GET requests don't need them
• Updates corresponding test to expect GET instead of POST

No security issues, bugs, or breaking changes detected. The fix addresses a legitimate API compatibility issue (405 Method Not Allowed errors).

*Automated review by [pr-reviewer](https://git.brooktrails.org/brooktrails/pr-reviewer) v0.15.0 | Safety Check | anthropic | tracking id `r-c623cb-46fe0c`* *This is an AI-generated review and may contain -istakes.* **Status:** ✅ Completed --- **✅ Verdict: LGTM** — The change correctly switches from POST to GET requests for registration token endpoints to match Forgejo 14.x API, with proper test updates. **Complexity:** trivial # Safety Check Review This PR fixes a compatibility issue with Forgejo 14.x by changing HTTP method from POST to GET for registration token endpoints. The changes are straightforward: - Changes HTTP method from `POST` to `GET` for all three registration token endpoints - Removes unnecessary JSON body and Content-Type header since GET requests don't need them - Updates corresponding test to expect GET instead of POST No security issues, bugs, or breaking changes detected. The fix addresses a legitimate API compatibility issue (405 Method Not Allowed errors).

rcsheets force-pushed fix/registration-token-get from 76fef160df to 7624c3852a 2026-03-27 06:29:37 +00:00 Compare

pr-reviewer-bot commented 2026-03-27 06:29:39 +00:00

Collaborator

Copy link

Automated review by pr-reviewer v0.15.0 | Safety Check | anthropic | tracking id r-c623d2-352c07
This is an AI-gene2ated review and may contain mistakes.

Status: ✅ Completed

---

✅ Verdict: LGTM — The changes correctly switch from POST to GET requests for registration token endpoints, which aligns with the Forgejo 14.x API behavior described in the PR.
Complexity: trivial

Safety Check Review

This PR fixes a legitimate API compatibility issue by changing HTTP method from POST to GET for Forgejo registration token endpoints. The changes are:

• Switches three endpoints from POST to GET requests
• Removes unnecessary JSON body and Content-Type headers (appropriate for GET)
• Updates corresponding test to expect GET method

The fix addresses the 405 Method Not Allowed errors mentioned in the description. No security concerns, breaking changes, or obvious bugs detected.

*Automated review by [pr-reviewer](https://git.brooktrails.org/brooktrails/pr-reviewer) v0.15.0 | Safety Check | anthropic | tracking id `r-c623d2-352c07`* *This is an AI-gene2ated review and may contain mistakes.* **Status:** ✅ Completed --- **✅ Verdict: LGTM** — The changes correctly switch from POST to GET requests for registration token endpoints, which aligns with the Forgejo 14.x API behavior described in the PR. **Complexity:** trivial # Safety Check Review This PR fixes a legitimate API compatibility issue by changing HTTP method from POST to GET for Forgejo registration token endpoints. The changes are: - Switches three endpoints from POST to GET requests - Removes unnecessary JSON body and Content-Type headers (appropriate for GET) - Updates corresponding test to expect GET method The fix addresses the 405 Method Not Allowed errors mentioned in the description. No security concerns, breaking changes, or obvious bugs detected.

rcsheets merged commit 48fb66c513 into master 2026-03-27 06:30:18 +00:00

rcsheets deleted branch fix/registration-token-get 2026-03-27 06:30:18 +00:00

rcsheets referenced this pull request from a commit 2026-03-27 06:30:18 +00:00

Merge pull request 'fix: use GET for registration token endpoints' (#19) from fix/registration-token-get into master

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

brooktrails/forgejo-runner-operator!19

No description provided.