brooktrails/forgejo-runner-operator
2
0
Fork 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity Actions

fix: regenerate CRD with optional tokenSecretRef #18

Merged
rcsheets merged 1 commit from fix/crd-optional-tokenref into master 2026-03-27 06:29:20 +00:00
Conversation 1 Commits 1 Files changed 1 +1 -1
rcsheets commented 2026-03-27 06:28:48 +00:00
Owner
Copy link

The CRD was not regenerated when tokenSecretRef was made optional,
causing Flux dry-run validation to reject RunnerPools without it.

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

The CRD was not regenerated when tokenSecretRef was made optional, causing Flux dry-run validation to reject RunnerPools without it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
fix: regenerate CRD with optional tokenSecretRef
Some checks failed
CI / ci (push) Has been cancelled
Details
CI / ci (pull_request) Has been cancelled
Details
E2E smoke test / e2e (pull_request) Has been cancelled
Details
70cf4e4e39 
The CRD was not regenerated when tokenSecretRef was made optional,
causing Flux dry-run validation to reject RunnerPools without it.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pr-reviewer-bot commented 2026-03-27 06:28:50 +00:00
Collaborator
Copy link

Automated review by pr-reviewer v0.15.0 | Safety Check | anthropic | tracking id r-c623a1-0298ad
This is an AI-generated review and may contain mistakes.

Status: ✅ Completed

✅ Verdict: LGTM — The change correctly removes the required field constraint for tokenSecretRef and adds documentation explaining when it's optional.
Complexity: trivial

This is a straightforward CRD regeneration that removes tokenSecretRef from the required fields list and adds clarifying documentation. The change aligns with the PR description's goal of fixing Flux dry-run validation for RunnerPools that don't specify a token secret when using a global controller token. No security or logic concerns.

*Automated review by [pr-reviewer](https://git.brooktrails.org/brooktrails/pr-reviewer) v0.15.0 | Safety Check | anthropic | tracking id `r-c623a1-0298ad`* *This is an AI-generated review and may contain mistakes.* **Status:** ✅ Completed --- **✅ Verdict: LGTM** — The change correctly removes the required field constraint for tokenSecretRef and adds documentation explaining when it's optional. **Complexity:** trivial This is a straightforward CRD regeneration that removes `tokenSecretRef` from the required fields list and adds clarifying documentation. The change aligns with the PR description's goal of fixing Flux dry-run validation for RunnerPools that don't specify a token secret when using a global controller token. No security or logic concerns.
rcsheets merged commit 353afbdd68 into master 2026-03-27 06:29:20 +00:00
rcsheets deleted branch fix/crd-optional-tokenref 2026-03-27 06:29:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
brooktrails/forgejo-runner-operator!18
No description provided.