brooktrails/forgejo-runner-operator
2
0
Fork 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity Actions

feat: capture controller reconciliation errors to Sentry/GlitchTip #14

Merged
rcsheets merged 1 commit from feat/controller-sentry-errors into master 2026-03-26 21:13:46 +00:00
Conversation 1 Commits 1 Files changed 1 +52
rcsheets commented 2026-03-26 21:12:21 +00:00
Owner
Copy link

Add captureError calls throughout the RunnerPool controller for all
error paths: build_forgejo_client, get_registration_token,
reconcile_registration_secret, build/create/get/update deployment,
build_configmap, reconcile_configmap, create_remote_backend, list_vms.
Each error includes pool name and step tags.

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

Add captureError calls throughout the RunnerPool controller for all error paths: build_forgejo_client, get_registration_token, reconcile_registration_secret, build/create/get/update deployment, build_configmap, reconcile_configmap, create_remote_backend, list_vms. Each error includes pool name and step tags. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
feat: capture controller reconciliation errors to Sentry/GlitchTip
Some checks failed
CI / ci (push) Has been cancelled
Details
CI / ci (pull_request) Has been cancelled
Details
E2E smoke test / e2e (pull_request) Has been cancelled
Details
6cf6fdf92c 
Add captureError calls throughout the RunnerPool controller for all
error paths: build_forgejo_client, get_registration_token,
reconcile_registration_secret, build/create/get/update deployment,
build_configmap, reconcile_configmap, create_remote_backend, list_vms.
Each error includes pool name and step tags.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pr-reviewer-bot commented 2026-03-26 21:12:24 +00:00
Collaborator
Copy link

Automated review by pr-reviewer v0.15.0 | Safety Check | anthropic | tracking id r-c5a136-88d4a9
This is an AI-generated review and may contain mistakes.

Status: ✅ Completed

✅ Verdict: LGTM — The changes add error reporting to Sentry/GlitchTip throughout the controller with proper scoping and no obvious security or logic issues.
Complexity: moderate

Safety Check Review

This PR adds Sentry error capture throughout the RunnerPool controller reconciliation process. The changes are straightforward and safe:

✅ Error handling: All captureError calls are added to existing error paths without changing the control flow
✅ Scoping: The captureError function properly uses Sentry scopes with pool and step tags
✅ Null safety: Checks if Sentry client is configured before attempting to capture errors
✅ Status updates: New setErrorStatus method appropriately updates pool status and metrics on errors

No security vulnerabilities, breaking changes, or obvious bugs detected. The Sentry integration is properly implemented with defensive programming practices.

*Automated review by [pr-reviewer](https://git.brooktrails.org/brooktrails/pr-reviewer) v0.15.0 | Safety Check | anthropic | tracking id `r-c5a136-88d4a9`* *This is an AI-generated review and may contain mistakes.* **Status:** ✅ Completed --- **✅ Verdict: LGTM** — The changes add error reporting to Sentry/GlitchTip throughout the controller with proper scoping and no obvious security or logic issues. **Complexity:** moderate ## Safety Check Review This PR adds Sentry error capture throughout the RunnerPool controller reconciliation process. The changes are straightforward and safe: ✅ **Error handling**: All `captureError` calls are added to existing error paths without changing the control flow ✅ **Scoping**: The `captureError` function properly uses Sentry scopes with pool and step tags ✅ **Null safety**: Checks if Sentry client is configured before attempting to capture errors ✅ **Status updates**: New `setErrorStatus` method appropriately updates pool status and metrics on errors No security vulnerabilities, breaking changes, or obvious bugs detected. The Sentry integration is properly implemented with defensive programming practices.
rcsheets merged commit 9490cb8f37 into master 2026-03-26 21:13:46 +00:00
rcsheets deleted branch feat/controller-sentry-errors 2026-03-26 21:13:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
brooktrails/forgejo-runner-operator!14
No description provided.