brooktrails/forgejo-runner-operator

Fork 0

fix: run make generate before tests in publish workflow #24

Merged

rcsheets merged 1 commit from feat/ci-versioned-publish into master

2026-03-28 20:57:19 +00:00

rcsheets commented

2026-03-28 20:48:56 +00:00

Owner

The protobuf and deepcopy generated code must be present before
go test can compile the project.

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

The protobuf and deepcopy generated code must be present before go test can compile the project. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

rcsheets added 1 commit

2026-03-28 20:48:56 +00:00

fix: run make generate before tests in publish workflow

CI / ci (pull_request) Waiting to run

Details

CI / ci (push) Has been cancelled

Details

5cabca36a5

The protobuf and deepcopy generated code must be present before
go test can compile the project.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

pr-reviewer-bot commented

2026-03-28 20:48:57 +00:00

Collaborator

Automated review by pr-reviewer v0.15.0 | Safety Check | anthropic | tracking id r-c83eb8-48ac8a
This is an AI-generated review and may contain mistakes.

Status: ✅ Completed

✅ Verdict: LGTM — The change adds necessary code generation step before tests run, fixing a legitimate build issue.
Complexity: trivial

Safety Check Review

This PR adds a code generation step to the CI workflow before tests run. The change:

Adds protobuf compiler dependencies to the build environment
Installs Go protobuf code generators
Runs make generate to create required generated code

This addresses a real build issue where protobuf and deepcopy generated code is required for go test to compile successfully. The additions are standard tooling and the approach is correct for Go projects using code generation.

Nothing alarming found - this is a straightforward CI fix.

*Automated review by [pr-reviewer](https://git.brooktrails.org/brooktrails/pr-reviewer) v0.15.0 | Safety Check | anthropic | tracking id `r-c83eb8-48ac8a`* *This is an AI-generated review and may contain mistakes.* **Status:** ✅ Completed --- **✅ Verdict: LGTM** — The change adds necessary code generation step before tests run, fixing a legitimate build issue. **Complexity:** trivial # Safety Check Review This PR adds a code generation step to the CI workflow before tests run. The change: - Adds protobuf compiler dependencies to the build environment - Installs Go protobuf code generators - Runs `make generate` to create required generated code This addresses a real build issue where protobuf and deepcopy generated code is required for `go test` to compile successfully. The additions are standard tooling and the approach is correct for Go projects using code generation. Nothing alarming found - this is a straightforward CI fix.

rcsheets force-pushed feat/ci-versioned-publish from 5cabca36a5

CI / ci (pull_request) Waiting to run

Details

CI / ci (push) Has been cancelled

Details

to b6b8ee2410

CI / ci (push) Successful in 1m19s

Details

CI / ci (pull_request) Successful in 1m20s

Details

2026-03-28 20:49:02 +00:00

Compare

pr-reviewer-bot commented

2026-03-28 20:49:04 +00:00

Collaborator

Automated review by pr-reviewer v0.15.0 | Safety Check | anthropic | tracking id r-c83ebf-0cebb8
This is an AI-generated review and may contain mistakes.

Status: ✅ Completed

✅ Verdict: LGTM — This adds required protobuf code generation before tests run in the CI pipeline, which is a reasonable fix for build dependencies.
Complexity: trivial

Safety Check Review

This change adds protobuf code generation to the CI workflow before tests run. The diff shows:

Installation of protobuf compiler dependencies
Installation of Go protobuf generators
Running make generate to create the required generated code

This appears to be a straightforward fix for a build dependency issue where generated protobuf/deepcopy code needs to exist before go test can compile the project. No security concerns or breaking changes identified.

*Automated review by [pr-reviewer](https://git.brooktrails.org/brooktrails/pr-reviewer) v0.15.0 | Safety Check | anthropic | tracking id `r-c83ebf-0cebb8`* *This is an AI-generated review and may contain mistakes.* **Status:** ✅ Completed --- **✅ Verdict: LGTM** — This adds required protobuf code generation before tests run in the CI pipeline, which is a reasonable fix for build dependencies. **Complexity:** trivial # Safety Check Review This change adds protobuf code generation to the CI workflow before tests run. The diff shows: - Installation of protobuf compiler dependencies - Installation of Go protobuf generators - Running `make generate` to create the required generated code This appears to be a straightforward fix for a build dependency issue where generated protobuf/deepcopy code needs to exist before `go test` can compile the project. No security concerns or breaking changes identified.